Update defaults for NorMuon#54
Merged
JohnLangford merged 3 commits intomicrosoft:mainfrom Apr 8, 2026
Merged
Conversation
Since use_gram_newton_schulz now defaults to True, a missing package produces a confusing bare ImportError. Wrap the import in try/except with an actionable message, matching the existing use_triton pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes all changes from #53 plus an additional fix for a clear error message when the
gram-newton-schulzpackage is missing.Changes
use_gram_newton_schulzdefault:False→Trueuse_polar_expressdefault:False→Trueadjust_lrdefault:"rms_norm"→"spectral_norm"gram_newton_schulzimport in try/except with actionable error message (matching the existinguse_tritonpattern)Supersedes #53.